Skip to content

feat: do not test in Plone 6.2#323

Merged
davisagli merged 1 commit into4.xfrom
erral-remove-plone-6.2-testing
Feb 2, 2026
Merged

feat: do not test in Plone 6.2#323
davisagli merged 1 commit into4.xfrom
erral-remove-plone-6.2-testing

Conversation

@erral
Copy link
Member

@erral erral commented Jan 28, 2026 •
edited
Loading

  • I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Contributing to Plone.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

This branch targets Plone 6.1, so no need to test in Plone 6.2

@mister-roboto
Copy link

mister-roboto commented Jan 28, 2026

@erral thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@erral
Copy link
Member Author

erral commented Jan 28, 2026

@jenkins-plone-org please run jobs

@erral erral requested a review from gforcada January 28, 2026 10:42
davisagli
davisagli reviewed Jan 30, 2026
View reviewed changes
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-matrix.yml is generated when we run plone/meta. So please also update .meta.toml here: https://github.com/plone/plone.app.content/blob/master/.meta.toml#L9

@erral erral force-pushed the erral-remove-plone-6.2-testing branch from d3d7f0a to 25412ad Compare February 2, 2026 12:13
@erral
Copy link
Member Author

erral commented Feb 2, 2026

I have updated the .meta.toml file to include only 6.0 and 6.1 and run plone.meta over it to have the workflows updated.

@erral
Copy link
Member Author

erral commented Feb 2, 2026

@jenkins-plone-org please run jobs

davisagli
davisagli approved these changes Feb 2, 2026
View reviewed changes
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erral Thanks!

@davisagli davisagli merged commit b419485 into 4.x Feb 2, 2026
11 checks passed
@davisagli davisagli deleted the erral-remove-plone-6.2-testing branch February 2, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davisagli davisagli davisagli approved these changes

@gforcada gforcada Awaiting requested review from gforcada

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erral @mister-roboto @davisagli